Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: Adding maintenance operator charts #1191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

task: Adding maintenance operator charts #1191

wants to merge 1 commit into from

Conversation

heyvister1
Copy link
Contributor

Adding maintenance operator charts

@heyvister1 heyvister1 added the on hold This enhancement is currently on hold pending additional clarification and evaluation label Nov 26, 2024
@heyvister1 heyvister1 changed the title Adding maintenance operator charts [WIP] task: Adding maintenance operator charts [WIP] Nov 26, 2024
@coveralls
Copy link
Collaborator

coveralls commented Nov 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12135526446

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.7%) to 60.541%
Changes Missing Coverage Covered Lines Changed/Added Lines %
hack/release.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
hack/release.go 1 0.0%
controllers/nicclusterpolicy_controller.go 1 78.66%
controllers/hostdevicenetwork_controller.go 2 89.77%
Totals Coverage Status
Change from base Build 12103893894: 0.7%
Covered Lines: 3337
Relevant Lines: 5512
💛 - Coveralls

@heyvister1 heyvister1 changed the title task: Adding maintenance operator charts [WIP] task: Adding maintenance operator charts Dec 3, 2024
almaslennikov
almaslennikov requested changes Dec 3, 2024
View reviewed changes
deployment/network-operator/values.yaml Outdated
maintenance-operator-chart:
operator:
image:
repository: gghcr.io/mellanox
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here, use make release-build to propagate the changes from hack/release.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@almaslennikov
Copy link
Collaborator

@rollandf do we merge with the documentation CI failing? Looks like some token is not set up there

@heyvister1
Copy link
Contributor Author

@rollandf do we merge with the documentation CI failing? Looks like some token is not set up there

Its pending a fix which I have introduced
Mellanox/network-operator-docs#134
PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rollandf rollandf rollandf approved these changes

@almaslennikov almaslennikov almaslennikov approved these changes

Assignees
No one assigned
Labels
on hold This enhancement is currently on hold pending additional clarification and evaluation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heyvister1 @coveralls @almaslennikov @rollandf